[MENFORCER-194] Rule RequireSameVersions: dependency artifacts are not checked

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 1.3.1
• Component/s: Standard Rules
• Labels: up-for-grabs
• Flags: Patch
• Assignee: Robert Scholte
• Reporter: Rod Woo
• Created: 07/Jun/14 11:40
• Updated: 01/Aug/20 11:58
• Resolved: 01/Aug/20 11:57

Description

In RequireSameVersions.java you must prefer the method project.getDependencyArtifacts() to project.getArtifacts().

Testcase and patch are attached.

Furthermore, the official documentation of the rule should make clear that transitive dependencies are not considered. This will make the rule for many users meaningless.

Furthermore, the official documentation of the rule should make clear that the test coverage of the rule implementation is small.

Issue Links

• is broken by: MENFORCER-156 Upgrading maven-enforcer-plugin from 1.2 to 1.3 breaks maven-assembly-plugin
• is related to: MENFORCER-230 Document support for transitive dependencies in enforcer plugins
• links to: GitHub Pull Request #76