Uploaded image for project: 'Maven EJB Plugin'
  1. Maven EJB Plugin
  2. MEJB-97

Remove param properties that doesn't make sense for CLI usage

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.1
    • Fix Version/s: 3.0.0
    • Labels:
      None
    • Environment:
      n/a

      Description

      Currently the plugin supports configuring several of the parameters via CLI properties. This doesn't make sense in many cases and encourages bad Maven usage (builds should be reproducible). Remove the properties for those parameters. The v3.0.0 release is a good time to do this.

      First of all we need to identify candidates for removal.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #9054 (See https://builds.apache.org/job/maven-plugins/9054/)
        MEJB-97 Remove param properties that doesn't make sense for CLI usage
        o Removed maven.ejb.jarName, maven.ejb.classifier, maven.ejb.clientClassifier,
        maven.ejb.ejbJar, maven.ejb.generateClient, maven.ejb.ejbVersion,
        maven.ejb.escapeBackslashesInFilePath, maven.ejb.escapeString,
        maven.ejb.filterDeploymentDescriptor. (khmarbaise: http://svn.apache.org/viewvc/?view=rev&rev=1804689)

        • (edit) maven-ejb-plugin/src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java
        • (edit) maven-ejb-plugin/src/site/apt/index.apt.vm
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #9054 (See https://builds.apache.org/job/maven-plugins/9054/ ) MEJB-97 Remove param properties that doesn't make sense for CLI usage o Removed maven.ejb.jarName, maven.ejb.classifier, maven.ejb.clientClassifier, maven.ejb.ejbJar, maven.ejb.generateClient, maven.ejb.ejbVersion, maven.ejb.escapeBackslashesInFilePath, maven.ejb.escapeString, maven.ejb.filterDeploymentDescriptor. (khmarbaise: http://svn.apache.org/viewvc/?view=rev&rev=1804689 ) (edit) maven-ejb-plugin/src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java (edit) maven-ejb-plugin/src/site/apt/index.apt.vm
        Hide
        khmarbaise Karl Heinz Marbaise added a comment -

        Fixed in r1804689

        Show
        khmarbaise Karl Heinz Marbaise added a comment - Fixed in r1804689
        Hide
        khmarbaise Karl Heinz Marbaise added a comment - - edited

        The maven.ejb.ejbJar, maven.ejb.escapeBackslashesInFilePath, maven.ejb.escapeString, maven.ejb.filterDeploymentDescriptor, maven.ejb.ejbVersion, maven.ejb.classifier should be removed as property cause this should be configured in the pom.xml

        Show
        khmarbaise Karl Heinz Marbaise added a comment - - edited The maven.ejb.ejbJar , maven.ejb.escapeBackslashesInFilePath , maven.ejb.escapeString , maven.ejb.filterDeploymentDescriptor , maven.ejb.ejbVersion , maven.ejb.classifier should be removed as property cause this should be configured in the pom.xml
        Hide
        khmarbaise Karl Heinz Marbaise added a comment -

        The generateClient should be removed as property. Can be configured in the pom file.

        Show
        khmarbaise Karl Heinz Marbaise added a comment - The generateClient  should be removed as property. Can be configured in the pom file.
        Hide
        khmarbaise Karl Heinz Marbaise added a comment -

        The jarname can not be set via a property anymore. This can be handled by using

        <build>
          <finalName>..</finalName>
        .
        </build>
        

        if really needed.

        Show
        khmarbaise Karl Heinz Marbaise added a comment - The jarname can not be set via a property anymore. This can be handled by using <build> <finalName> .. </finalName> . </build> if really needed.

          People

          • Assignee:
            khmarbaise Karl Heinz Marbaise
            Reporter:
            afloom Anders Hammar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development