Uploaded image for project: 'Meecrowave'
  1. Meecrowave
  2. MEECROWAVE-86

Typo in TomcatAutoInitializer.java causes jsp pages not picked up by meecrowave.

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.2.0
    • 1.2.0
    • None

    Description

      https://github.com/apache/meecrowave/blob/trunk/meecrowave-core/src/main/java/org/apache/meecrowave/tomcat/TomcatAutoInitializer.java
      Typo in TomcatAutoInitializer.java causes jsp pages processed by Tomcat Default Servlet instead of Tomcat Jsp Servlet.

      final ServletRegistration.Dynamic def = ctx.addServlet("default", DefaultServlet.class);
      def.setInitParameter("listings", "false");
      def.setInitParameter("debug", "0");
      def.setLoadOnStartup(1);
      def.addMapping("/");
      
      try {
          final String jsp = "org.apache.jasper.servlet.JspServlet";
          TomcatAutoInitializer.class.getClassLoader().loadClass(jsp);
          final ServletRegistration.Dynamic jspDef = ctx.addServlet("jsp", jsp);
          if (jspDef != null) {
              jspDef.setInitParameter("fork", "false");
              jspDef.setInitParameter("xpoweredBy", "false");
              jspDef.setInitParameter("development", "false");
              jspDef.setLoadOnStartup(3);
              def.addMapping("*.jsp");  // Should be --- jspDef.addMapping("*.jsp");
              def.addMapping("*.jspx"); // Should be --- jspDef.addMapping("*.jspx");
          }
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            struberg Mark Struberg
            Ravisankar Challa Ravisankar Challa
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment