[MECLIPSE-399] URL for javadoc attachments on Unix is invalid

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4
• Fix Version/s: 2.5
• Environment: Unix, Eclipse 3.3
• Flags: Patch
• Assignee: Arnaud Heritier
• Reporter: Benjamin Bentmann
• Created: 12/Mar/08 17:23
• Updated: 05/Apr/15 14:43
• Resolved: 13/Mar/08 21:11

Description

Currently, the plugin constructs the URL for the javadoc attachment via

"jar:file:/" + javadocpath + "!/"

Now, consider a unix path like "/home/me/.m2/<snip>.jar". This will produce the URL "jar:file://home/me/.m2/<snip>.jar!/". Note the double slash after "file:" which will cause "home" to be parsed as a hostname instead of a directory. This misinterpretation makes Eclipse fail to access the javadocs. Acceptable URLs would either be "jar:file:/home/..." or "jar:file:///home/...".

The simple solution is to use java.io.File.toURI() for this job. This method will not only properly handle slashes but also care for encoding of characters that may appear in filesystem paths but are illegal in URLs (most prominently spaces).