[MDEPLOY-205] MavenProject with only attachments must have packaging "pom"

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-M1
• Assignee: Robert Scholte
• Reporter: Robert Scholte
• Created: 09/Jan/16 16:32
• Updated: 27/Dec/21 13:57
• Resolved: 12/Jan/16 21:22

Description

According to svn blame MDEPLOY-78 is responsible for this piece of code:

if ( isPomArtifact )
            {
                deployableArtifacts.add( artifact );
            }
            else
            {
                File file = artifact.getFile();

                if ( file != null && file.isFile() )
                {
                    deployableArtifacts.add( artifact );
                }
                else if ( !attachedArtifacts.isEmpty() )
                {
                    getLog().info( "No primary artifact to deploy, deploying attached artifacts instead." );

                    Artifact pomArtifact =
                        artifactFactory.createProjectArtifact( artifact.getGroupId(), artifact.getArtifactId(),
                                                               artifact.getBaseVersion() );
                    pomArtifact.setFile( pomFile );
                    if ( request.isUpdateReleaseInfo() )
                    {
                        pomArtifact.setRelease( true );
                    }

                    deployableArtifacts.add( pomArtifact );

                    // propagate the timestamped version to the main artifact for the attached artifacts to pick it up
                    artifact.setResolvedVersion( pomArtifact.getVersion() );
                }
                else
                {
                    String message = "The packaging for this project did not assign a file to the build artifact";
                    throw new MojoExecutionException( message );
                }
            }

I don't like the else if-clause. IMHO if there's no main artifact, the packaging should simply be 'pom'.

Issue Links

• causes: MDEPLOY-288 Deploy is failed when no primary artifact is present
• relates to: MDEPLOY-45 Classifier not supported by deploy:deploy
• relates to: MDEPLOY-78 Deploy with classifier does not deploy pom