[MDEPLOY-201] deployAtEnd issue for multi-module projects

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.1, 2.8.2
• Component/s: deploy:deploy
• Labels: needs-attention
• Assignee: Unassigned
• Reporter: David Szervanszky
• Created: 17/Sep/15 14:04
• Updated: 11/Nov/22 10:28
• Resolved: 20/Oct/22 07:14

Description

There appears to be a bug with the deployAtEnd feature when the maven project includes
a parent module which is not part of the build.
Eg: Includes a release parent pom with some standard config.

The bug is that the code is using the size of the reactorProjects list and this includes
the parent which isn't in the build process. This is causing the code to not perform any
deployments at the end because it is expecting to see another module in the build
sequence so that READYPROJECTSCOUNTER matches the size of the reactorList and this never
happens.

A potential solution to this is to look at the MavenSession and get the top level project
which started the build. Then getting the index position of the top level project in the
reactorList and subtracting it from the total size of the reactorList will give the
correct number of expected build modules.

We have tested these changes locally and the solution appears to work.
But are currently unsure as to how the testing is done for this project.

Issue Links

• relates to: MDEPLOY-176 With DeployAtEnd activated and a project using customized lifecycle plugin, deploy is skipped
• relates to: MDEPLOY-193 deployAtEnd does not deploy artifacts for multi-module project with build extensions
• relates to: MDEPLOY-157 Add deployAtEnd option for multimodule projects