[MDEP-715] Hamcrest used and unused

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: analyze
• Labels: S2 intern
• Assignee: Unassigned
• Reporter: Elliotte Rusty Harold
• Created: 20/Jul/20 12:17
• Updated: 03/Oct/20 00:16

Description

This is something I've seen when analyzing several Maven plugins. For example, maven-shared-utils circa July 20, 2020:

 

[WARNING] Used undeclared dependencies found:
[WARNING] org.hamcrest:hamcrest:jar:2.2:test
[WARNING] org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M2a:test
[WARNING] Unused declared dependencies found:
[WARNING] org.hamcrest:hamcrest-core:jar:2.2:test
[WARNING] org.apache.maven:maven-core:jar:3.1.0:test
[WARNING] org.codehaus.plexus:plexus-container-default:jar:2.1.0:provided

 

Easy fix, right? don't declare org.hamcrest:hamcrest-core:jar:2.2:test and instead declare org.hamcrest:hamcrest:jar:2.2:test

 

But when I do that:

 

[WARNING] Used undeclared dependencies found:
[WARNING] org.hamcrest:hamcrest-core:jar:1.3:test
[WARNING] org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M2a:test
[WARNING] Unused declared dependencies found:
[WARNING] org.hamcrest:hamcrest:jar:2.2:test
[WARNING] org.apache.maven:maven-core:jar:3.1.0:test
[WARNING] org.codehaus.plexus:plexus-container-default:jar:2.1.0:provided

 

Figure out what's going on here and fix it. Is hamcrest-core needed and used or not? is hamcrest needed and used or not? Be consistent.