[MDEP-501] Filtering dependencies does not retain the order of the unfiltered list

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.10
• Fix Version/s: 3.0.1
• Assignee: Michael Osipov
• Reporter: Beirtí Ó'Nunáin
• Created: 07/Sep/15 12:25
• Updated: 10/Jan/18 13:00
• Resolved: 10/Jan/18 13:00

Description

If you use the build-classpath mojo, you get the dependency list as specified in the pom. However, if you introduce filtering, you end up losing the dependency order. It seems that the org.apache.maven.shared.artifact.filter.collection.ArtifactsFilter declares 'Set' instead of 'SortedSet' and that the org.apache.maven.shared.artifact.filter.collection.AbstractArtifactFeatureFilter returns a HashSet instead of a LinkedHashSet, even though a LinkedHashSet is being passed in.

The impact of this is that you cannot generate a correctly-ordered classpath when using filters. The fix is very straightforward, simply change the filterIncludes and filterExcludes methods of AbstractArtifactFeatureFilter to use a LinkedHashSet.

Issue Links

• is cloned by: MSHARED-466 Filtering dependencies does not retain the order of the unfiltered list