Uploaded image for project: 'Maven Dependency Plugin'
  1. Maven Dependency Plugin
  2. MDEP-482

Can't use both outputProperty and outputFile in build-classpath mojo

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.10
    • Fix Version/s: 3.0.1
    • Component/s: build-classpath
    • Labels:
      None
    • Flags:
      Patch

      Description

      When defining the configuration for the dependency:build-classpath mojo, a user can use either <outputProperty> and <outputFile> to define the desired output of the classpath string. These both work as expected.

      However, if the user wishes to use both output methods in conjunction, the <outputFile> gets discarded and only <ouputProperty> is used.

      A current workaround that achieves the desired missing behavior involves defining two different executions for the mojo only differing by the output method.

        Activity

        Hide
        dagandlerx Dagan Sandler added a comment -

        Attaching a really simple patch that allows usage of both output methods.

        Note: I am a little new to this. Patched the trunk. Does this mean it will only apply to 2.11 if accepted?

        Show
        dagandlerx Dagan Sandler added a comment - Attaching a really simple patch that allows usage of both output methods. Note: I am a little new to this. Patched the trunk. Does this mean it will only apply to 2.11 if accepted?
        Hide
        gboue Guillaume Boué added a comment -

        Fixed in r1774803.

        Show
        gboue Guillaume Boué added a comment - Fixed in r1774803 .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #7797 (See https://builds.apache.org/job/maven-plugins/7797/)
        MDEP-482 Can't use both outputProperty and outputFile in build-classpath mojo
        Submitted by: Dagan Sandler

        Make sure outputFile and outputProperty can both be used at the same time. Applied patch after adding an IT. (gboue: http://svn.apache.org/viewvc/?view=rev&rev=1774803)

        • (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property
        • (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property/invoker.properties
        • (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property/pom.xml
        • (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property/test.properties
        • (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property/verify.bsh
        • (edit) maven-dependency-plugin/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #7797 (See https://builds.apache.org/job/maven-plugins/7797/ ) MDEP-482 Can't use both outputProperty and outputFile in build-classpath mojo Submitted by: Dagan Sandler Make sure outputFile and outputProperty can both be used at the same time. Applied patch after adding an IT. (gboue: http://svn.apache.org/viewvc/?view=rev&rev=1774803 ) (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property/invoker.properties (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property/pom.xml (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property/test.properties (add) maven-dependency-plugin/src/it/projects/build-classpath-output-file-and-property/verify.bsh (edit) maven-dependency-plugin/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java

          People

          • Assignee:
            gboue Guillaume Boué
            Reporter:
            dagandlerx Dagan Sandler
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development