Uploaded image for project: 'Maven Compiler Plugin'
  1. Maven Compiler Plugin
  2. MCOMPILER-385

Minor performance improvements in CompilerMojo

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 3.9.0
    • None

    Description

      There are a couple of opportunities to improve performance and simplify CompilerMojo's preparePaths() method.

      A StringBuilder is used to concatenate 3 strings. String.format() will be neater here.

      Secondly, the compilerArgs array is checked for null and initialised if so in two separate places. Since this check is always performed, doing it earlier will allow one check to be removed.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            olamy Olivier Lamy
            rhowe Russell Howe
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment