Uploaded image for project: 'Maven Compiler Plugin'
  1. Maven Compiler Plugin
  2. MCOMPILER-330

Add java.* JPMS modules for testing only is hard

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.7.0
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      Windows 10, Maven v3.5.2

      Description

      Attached is a project demonstrating this issue (which affects both compiler and surefire). The basic problem here is where the project depends on a java.* module for testing but not at compile time. For example, the test code depends on `java.desktop` module, but the main code does not.

      While this has similarities with MCOMPILER-320 it is different because there is no way to refer to the `java.*` JPMS modules as dependencies.

      Right now the workaround is to add both --add-modules and --add-reads, as shown in the attachment. This is painful low-level stuff that Maven should be hiding the user from.

      NOTE: the attachment will succeed when run. Delete the compiler/surefire plugin config to see the issue.

      Rather than tackle this problem directly, my preference would be to have a module-patch.java file that allows users to declare additional dependencies/exports/services that only apply at testing time. This would be interpreted whenever --patch-module is being used. (As well as the example explained here, I've also run into the need to export packages that only exist in tests, and this currently also requires low-level argLine manipulation).

       

        Attachments

        1. maven-issue3.zip
          4 kB
          Stephen Colebourne

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              scolebourne@joda.org Stephen Colebourne
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: