[MCHECKSTYLE-375] Upgrade all test XML doctypes

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.1.0
• Component/s: checkstyle:check, checkstyle:checkstyle
• Assignee: Enrico Olivelli
• Reporter: richard
• Created: 24/Apr/19 18:25
• Updated: 23/Dec/20 09:01
• Resolved: 10/May/19 17:24

Description

The tests used to test maven-checkstyle are using old DTDs and unsecure "http" locations. This is related to CVE-2019-9658. The security issue is in the parser that is used to parse this file. It leaves any code that parses this file vulnerable to XXE via a MITM.

 

All doctypes used in maven-checkstyle repo (configurations, suppressions, import controls, etc...) should be updated to use the latest URL and public DOCTYPEs.

Example:
````

<!DOCTYPE module PUBLIC
          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
"https://checkstyle.org/dtds/configuration_1_3.dtd">

````

Issue Links

• links to: GitHub Pull Request #15