[MCHECKSTYLE-244] LicenseResourceManager component is not thread safe and causes parallel build failures

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.12, 2.12.1
• Fix Version/s: 2.13
• Assignee: Herve Boutemy
• Reporter: Konstantin Pokrovsky
• Created: 31/Jul/14 17:36
• Updated: 18/Aug/14 07:52
• Resolved: 18/Aug/14 07:52

Description

LicenseResouceManager component does not specify instantiation strategy. By default plexus uses singleton strategey which leads to ConcurrentModificationException in parallel maven builds.

Example: when two DefaultCheckstyleExecutors try to use one licence manager: one calls addSearchPath on FileResourceLoader while the other one iterating over paths in getResource on the same FileResourceLoader .

MCHECKSTYLE-238 and MCHECKSTYLE-230 are exactly about this situation. Right now the plugin for some reason is marked as thread safe although it definetly produces exceptions in parallel multimodule builds.

DefaultCheckstyleRssGenerator is a point of attention because it is also singleton instantiated.

Issue Links

• is related to: MCHECKSTYLE-230 ConcurrentModificationException in FileResourceLoader.getResource
• is related to: MCHECKSTYLE-238 ConcurrentModificationException