[MCHECKSTYLE-237] Changeset 1608113 introduces "Line 0" regression

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.13
• Fix Version/s: 2.13
• Component/s: checkstyle:checkstyle, checkstyle:checkstyle-aggregate
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 06/Jul/14 07:10
• Updated: 29/Oct/14 22:31
• Resolved: 09/Jul/14 15:22

Description

c1608113 introduced this:

-            int line = event.getLine();
             if ( getXrefLocation() != null )
             {
-                sink
-                    .link(
-                        getXrefLocation() + "/" + filename.replaceAll( "\\.java$", ".html" ) + "#L" + line );
+                sink.link( getXrefLocation() + "/" + filename.replaceAll( "\\.java$", ".html" ) + "#L"
+                    + event.getLine() );
+                sink.text( String.valueOf( event.getLine() ) );
+                sink.link_();
             }
-            if ( line != 0 )
+            else
             {
                 sink.text( String.valueOf( event.getLine() ) );
             }
-            if ( getXrefLocation() != null )
-            {
-                sink.link_();
-            }

I have intentionally added if ( line != 0 ) to avoid useless Line 0 links. Moreover, int line avoids repetitive calls to event.getLine().

That improvement should remain.