Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.10
    • Component/s: announcement
    • Labels:
      None
    • Flags:
      Patch

      Description

      Add an option to set ProjectJavamailMailSender.tlsEnabled to true, to allow to use as an example GMail to send announcement emails

      1. enableTls.patch
        2 kB
        Benoit Guerin

        Activity

        Benoit Guerin created issue -
        Benoit Guerin made changes -
        Field Original Value New Value
        Attachment enableTls.patch [ 62485 ]
        Hide
        Dennis Lundberg added a comment -

        Hello Benoit,

        Thank you for your patch. I've had a look at it and it looks good, but I have a question.

        In the ProjectJavamailMailSender.java file you set the startTls property if TLS is enabled. Shouldn't that code be inside the try/catch just above it? I.e. inside the if( isSslMode() ) statement? I imagine that SSL is required to be able to use TLS.

        Show
        Dennis Lundberg added a comment - Hello Benoit, Thank you for your patch. I've had a look at it and it looks good, but I have a question. In the ProjectJavamailMailSender.java file you set the startTls property if TLS is enabled. Shouldn't that code be inside the try/catch just above it? I.e. inside the if( isSslMode() ) statement? I imagine that SSL is required to be able to use TLS.
        Hide
        Dennis Lundberg added a comment -

        Never mind, after doing some testing I realized that SSL and TLS are mutually exclusive. I was able to send a test announcement using gmail as smtp server.

        I applied your patch in r1578534 with minor adjustments. Thanks!

        Show
        Dennis Lundberg added a comment - Never mind, after doing some testing I realized that SSL and TLS are mutually exclusive. I was able to send a test announcement using gmail as smtp server. I applied your patch in r1578534 with minor adjustments. Thanks!
        Dennis Lundberg made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Assignee Dennis Lundberg [ dennislundberg ]
        Fix Version/s 2.10 [ 19130 ]
        Hide
        Benoit Guerin added a comment -

        Great ! thanks !

        Show
        Benoit Guerin added a comment - Great ! thanks !
        Mark Thomas made changes -
        Project Import Sun Apr 05 09:14:45 UTC 2015 [ 1428225285377 ]
        Mark Thomas made changes -
        Workflow jira [ 12718136 ] Default workflow, editable Closed status [ 12749294 ]
        Mark Thomas made changes -
        Flags Patch [ 10430 ]
        Patch Submitted Yes [ 10763 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 22:40:15 UTC 2015 [ 1428273615853 ]
        Mark Thomas made changes -
        Workflow jira [ 12955547 ] Default workflow, editable Closed status [ 12992831 ]
        Mark Thomas made changes -
        Assignee dennislundberg [ dennislundberg ] Dennis Lundberg [ dennisl@apache.org ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        412d 7h 35m 1 Dennis Lundberg 17/Mar/14 14:48

          People

          • Assignee:
            Dennis Lundberg
            Reporter:
            Benoit Guerin
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development