Maven Changes Plugin
  1. Maven Changes Plugin
  2. MCHANGES-250

ccAddresses and bccAddresses should not be 'required'

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: announcement
    • Labels:
      None

      Description

      It seems unkind and unnecessary to require the cc and bcc. If one doesn't need them, why require them?

      1. MCHANGES-250.patch
        1 kB
        Benson Margulies

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        6d 18h 48m 1 Dennis Lundberg 31/May/11 14:50
        Mark Thomas made changes -
        Assignee dennislundberg [ dennislundberg ] Dennis Lundberg [ dennisl@apache.org ]
        Mark Thomas made changes -
        Workflow jira [ 12955519 ] Default workflow, editable Closed status [ 12992783 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 22:40:15 UTC 2015 [ 1428273615853 ]
        Mark Thomas made changes -
        Workflow jira [ 12718084 ] Default workflow, editable Closed status [ 12749437 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 09:14:45 UTC 2015 [ 1428225285377 ]
        Dennis Lundberg made changes -
        Resolution Fixed [ 1 ]
        Assignee Dennis Lundberg [ dennislundberg ]
        Fix Version/s 2.6 [ 17375 ]
        Status Open [ 1 ] Closed [ 6 ]
        Hide
        Dennis Lundberg added a comment -

        Fixed in r1129881.

        I went with the null check.

        Show
        Dennis Lundberg added a comment - Fixed in r1129881 . I went with the null check.
        Hide
        Benson Margulies added a comment -

        The code would crash without them. This looked neater than a bunch of checks for null.

        Unless by default maven injects empty lists

        Show
        Benson Margulies added a comment - The code would crash without them. This looked neater than a bunch of checks for null. Unless by default maven injects empty lists
        Hide
        Dennis Lundberg added a comment -

        Was it necessary to add default values fro the parameters?
        I imagine that it would be enough to just remove the @required annotations.

        Show
        Dennis Lundberg added a comment - Was it necessary to add default values fro the parameters? I imagine that it would be enough to just remove the @required annotations.
        Benson Margulies made changes -
        Field Original Value New Value
        Attachment MCHANGES-250.patch [ 55259 ]
        Benson Margulies created issue -

          People

          • Assignee:
            Dennis Lundberg
            Reporter:
            Benson Margulies
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development