[MBUILDCACHE-37] Allow disabled-by-default configuration

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Component/s: remote build cache
• Labels: pull-request-available
• Assignee: Olivier Lamy
• Reporter: Alexander Schwartz
• Created: 09/Jan/23 17:14
• Updated: 09/Jun/23 00:00
• Resolved: 13/Feb/23 10:33

Description

I'm trying to create a configuration where the extension is disabled by default and can be enabled by some key users as a opt-in. 

My first attempt: 

• in the XML, set `cache.configuration.enabled` to `false`
  -> This disables it by default
• On the CLI, set `-Dmaven.build.cache.enabled=true`
  -> This was intended to enable it "opt in" - but failed, see below.

The problem: 

The code in

https://github.com/apache/maven-build-cache-extension/blob/2d262e133749abb5163969b9c0b2f0f2056e7951/src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java#L181-L184

will use the "disable" state in the XML. 

Suggested change: `maven.build.cache.enabled` should override the setting `cache.configuration.enabled` in the XML. 

Issue Links

• links to: GitHub Pull Request #37