[MBUILDCACHE-16] Fix config file name

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Labels: pull-request-available
• Assignee: Guillaume Nodet
• Reporter: Herve Boutemy
• Created: 04/Mar/22 20:43
• Updated: 10/May/22 06:53
• Resolved: 10/May/22 06:53

Description

reported to me by someone trying to test:
I've noticed that all the docs state a file named maven-cache-config.xml but the source suggests it should be called maven-build-cache-config.xml:
https://github.com/apache/maven-build-cache-extension/blob/c92e48ef924e0f67a0e1299[…]/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java

Also maybe worth stating that the XXMM (memory mapped files) hash algorithm seems to require JDK9+ as it uses ByteBuffer.clear() somewhere - or at least, when I tried to use it, I saw a stacktrace with that - maybe some other extension/plugin interacting badly. It only seemed to happen with XXMM.

Exception in thread "main" java.lang.NoSuchMethodError: java.nio.ByteBuffer.clear()Ljava/nio/ByteBuffer;
	at org.apache.maven.buildcache.hash.ThreadLocalBuffer.clear(ThreadLocalBuffer.java:74)
	at org.apache.maven.buildcache.hash.ThreadLocalBuffer.get(ThreadLocalBuffer.java:47)
	at org.apache.maven.buildcache.hash.XXMM.checksum(XXMM.java:51)
	at org.apache.maven.buildcache.hash.HashFactory.createChecksum(HashFactory.java:77)
	at org.apache.maven.buildcache.checksum.MavenProjectInput.calculateChecksum(MavenProjectInput.java:201)
	at org.apache.maven.buildcache.DefaultProjectInputCalculator.calculateInputInternal(DefaultProjectInputCalculator.java:116)
	at org.apache.maven.buildcache.DefaultProjectInputCalculator.calculateInput(DefaultProjectInputCalculator.java:88)
	at org.apache.maven.buildcache.CacheControllerImpl.findCachedBuild(CacheControllerImpl.java:167)
	at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute(BuildCacheMojosExecutionStrateg

Issue Links

• links to: GitHub Pull Request #11