[MATH-887] "AbstractLeastSquares" cleanup

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: 3.0
• Labels: api-change
• Assignee: Gilles Sadowski
• Reporter: Gilles Sadowski
• Created: 30/Oct/12 01:03
• Updated: 10/Aug/13 01:27
• Resolved: 10/Aug/13 01:26

Description

Class "AbstractLeastSquares" (in package "o.a.c.m.optimization.general") has a lot of "protected" fields that are modified by its subclasses (e.g. "LevenbergMarquardt"). This decreases encapsulation which in turn makes the code more difficult to understand and modify.
I propose to deprecate (in 3.1) and remove or make "private" (in 4.0) all fields that could be hidden or should be modified through setter methods.

Part of the code could also be more readable (and self-documenting) by making use of higher-level constructs such as "RealMatrix" rather than using explicit loops.

Issue Links

• Is contained by: MATH-1008 Move the contents of "o.a.c.m.nonlinear.vector.jacobian" to the "o.a.c.m.fitting" package
• is superceded by: MATH-1008 Move the contents of "o.a.c.m.nonlinear.vector.jacobian" to the "o.a.c.m.fitting" package