Ok - I'm a bit confused by now and hope you can help me better understanding the submission process in this project.
That's because I started digressing...
- I assume that the two of you (Gilles & Sébastien) have SVN write access and would be able to commit my changes.
- My code needs to follow some guidelines before my changes are accepted. When my code meets these guidelines, then it will be submitted (given that the topic of the enhancement suits the project; something that should have been checked in the beginning via the mailing list. Anyway, guess we are already through this...).
In my view, we are not really through this. I'd rather know what's next, before we start a whole new class FilterUtils. I think there are real design decisions that should be made before we dash into committing. For example, the boundary conditions I was referring to. Should an enum be defined somewhere, with various boundary conditions? I'm interested in image analysis (same issues with 2D convolution), and various policies are adopted. I'm sure we will find other issues, which need to be discussed. Ideally, we would need some more people involved in signal analysis.
Now this leaves some questions open:
Yes, I am the culprit
- Who will the potential SVN submitter of the code I have written?
Whoever has some time to do it.
- It seems that there is some dissent about the rules -> Will the guy who will make the submission also "enforce" his rules or do we need to find a consent before any more commits are possible?
Formatting rules have always (in my view) been a bit fuzzy. It's true you learn by looking at existing code, but since some of the code does not comply with these non-written rules, you sometimes draw wrong conclusions. I personally have been contributing for a year and a half, and still do formatting errors. The discussion above should really not have taken place here, I'm sorry for that. For the time being, I would say: "follow the rules stated by Gilles", and ignore what I have said about formatting (except for the '.' at the end of the first sentence in javadocs).
Can we decide on the guidelines and fix them somewhere? This would make contributing for new users much easier... If existing code doesn't follow the rules, it could be cleaned up over time.
You are certainly not the first one to ask for this... I will try and write something in the developer's guide.
Please don't get me wrong - I'm the new guy here, don't know much about procedures and I'm aware that there are some and I need to follow them. However, I'd like to contribute to this library
We do not take you wrong. Your time is precious, and you do not want to spend it reformatting over and over again, just because noone told you how to properly format it in the first place. Thanks a lot for this first contribution, and the contributions to come (Please start a thread on the dev mailing list about these)!