Uploaded image for project: 'Commons Math'
  1. Commons Math
  2. MATH-799

Remove default values for tolerances in "AbstractConvergenceChecker"

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 4.0
    • Labels:

      Description

      The custom convergence checkers let users override the ad-hoc convergence criteria that most optimization algorithms provide.
      CM defines "simple" checkers that inherit from "AbstractConvergenceChecker" and use the default values provided in that class. However good values for the tolerances are problem-dependent.
      User control cannot come without the user paying attention to those values, or "strange" failures can happen (cf. issue MATH-798).

      It is thus proposed to remove the default values defined in "AbstractConvergenceChecker", and also to remove the default (no-arg) constructor for all the convergence checkers defined in CM, i.e.:

      • AbstractConvergenceChecker
      • SimpleValueChecker
      • SimpleUnivariateValueChecker
      • SimplePointChecker
      • SimpleVectorValueChecker

      In turn, this implies the removal of some of the constructors (which call the above constructors) in the following classes:

      • SimplexOptimizer
      • BaseAbstractMultivariateOptimizer
      • BaseAbstractMultivariateVectorOptimizer
      • CMAESOptimizer
      • BaseAbstractMultivariateSimpleBoundsOptimizer
      • AbstractScalarDifferentiableOptimizer
      • GaussNewtonOptimizer
      • AbstractLeastSquaresOptimizer
      • NonLinearConjugateGradientOptimizer
      • LevenbergMarquardtOptimizer

      To maintain backwards-compatibility, the fields and constructors will be deprecated but not removed until the preparation of release 4.0.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                erans Gilles Sadowski
                Reporter:
                erans Gilles Sadowski
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: