[MATH-793] OrderedTuple#hashCode() uses casting instead of boxing - ASF JIRA

XML

Word

Printable

JSON

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.1
Component/s: None
Labels:
None
Environment:
Hide

OrderedTuple#hashCode() is as follows:

public int hashCode() { return Arrays.hashCode(components) ^ ((Integer) offset).hashCode() ^ ((Integer) lsb).hashCode() ^ ((Boolean) posInf).hashCode() ^ ((Boolean) negInf).hashCode() ^ ((Boolean) nan).hashCode(); }

This is not the correct way to convert primitives to their object equivalents.

((Integer) x).hashCode() == x Boolean#hashCode() is defined as value ? 1231 : 1237

Note that this error won't be found unless the compiler emits warnings for boxing.
Show
OrderedTuple#hashCode() is as follows: public int hashCode() { return Arrays.hashCode(components) ^ (( Integer ) offset).hashCode() ^ (( Integer ) lsb).hashCode() ^ (( Boolean ) posInf).hashCode() ^ (( Boolean ) negInf).hashCode() ^ (( Boolean ) nan).hashCode(); } This is not the correct way to convert primitives to their object equivalents. (( Integer ) x).hashCode() == x Boolean #hashCode() is defined as value ? 1231 : 1237 Note that this error won't be found unless the compiler emits warnings for boxing.