[MATH-760] DescriptiveStatistics.windowSize has a getter and setter, but is protected, so subclasses can bypass the validation check in the setter

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 03/Mar/12 01:20
• Updated: 16/Feb/15 23:03
• Resolved: 16/Feb/15 23:03

Description

DescriptiveStatistics.windowSize has a setter which does validation and maintains the list if necessary.

However the field is protected, so classes can ignore the setter.

As it happens, this is exactly what the subclass ListUnivariateImpl.setWindowSize does.

The field should be made private.

Issue Links

• is duplicated by: MATH-1192 "Descriptive statistics" has a non-final protected field
• relates to: MATH-759 ListUnivariateImpl does not always access windowSize using synch.