Uploaded image for project: 'Commons Math'
  1. Commons Math
  2. MATH-719

Strange deprecations in API

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Later
    • Affects Version/s: 2.0, 2.1, 2.2
    • Fix Version/s: None

      Description

      Sorry if this doesn't belong here. I couldn't find any sort of mailing list or other feedback mechanism on the website.

      RealMatrix has some very odd deprecations. In particular inverse(), getDeterminant() and isSingular(). The last has the message:

      Deprecated. as of release 2.0, replaced by the boolean negation of new LUDecompositionImpl(m).getSolver().isNonSingular()

      That's an implementation, not an interface. The whole point of having an interface is that

      • I can query whether a matrix is singular withou having to know about LUDecompositions
      • You guys can change the implementation of isSingular() if something better pops up without us guys having to change our code.

      I'm not using these methods now, because they're deprecated, but I've basically recreated them in as static methods in a utility class. Wouldn't it be much better to just put code from the deprecation message into the method and remove the deprecation?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              pbloem Peter Bloem
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: