[MATH-512] "GaussianFitter" could inherit from "CurveFitter"

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0
• Assignee: Unassigned
• Reporter: Gilles Sadowski
• Created: 15/Feb/11 09:57
• Updated: 24/Mar/12 16:16
• Resolved: 18/Feb/11 16:47

Description

Currently, the "GaussianFitter" class contains a "CurveFitter" instance (and delegates most method calls to it) for the sake of being able to return a "GaussianFunction" instance (from the call to the "fit" method).
I think that it would clearer (in the context of the "fitting" package) that "fit" returns an array of doubles (as "CurveFitter" does). The user can then easily create a "Gaussian" function object, if needed.
[Also, note that the "GaussianFitter" actually fits the sum of a constant and a Gaussian function; thus the name is slightly misleading IMO.]
I also think that "ParametricGaussianFunction" and "GaussianParametersGuesser" should become inner classes of "GaussianFitter" (as this makes it clear what their use is).

Issue Links

• is related to: MATH-513 Moving the "ParametricRealFunction" interface