[MATH-467] HarmonicCoefficientsGuesser.sortObservations() potentlal NPE warning

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2, 3.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 06/Jan/11 14:49
• Updated: 23/Mar/11 20:30
• Resolved: 06/Jan/11 19:43

Description

HarmonicCoefficientsGuesser.sortObservations()

generates an NPE warning from Eclipse which thinks that mI can be null in the while condition.

The code looks like:

WeightedObservedPoint mI = observations[i];
while ((i >= 0) && (curr.getX() < mI.getX())) {
    observations[i + 1] = mI;
    if (i-- != 0) {
        mI = observations[i];
    } else {
        mI = null;
    }
}
// mI is not used further

It looks to me as though the "mI = null" statement is either redundant or wrong - why would one want to replace one of the observations with null during a sort?