Uploaded image for project: 'Commons Math'
  1. Commons Math
  2. MATH-365

Issue with "SmoothingBicubicSplineInterpolator"

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.2
    • Labels:
      None

      Description

      I figured out that the name of this class is misleading as the implementation doesn't perform the intended smoothing.

      In order to solve this issue, I propose to:

      1. deprecate the "SmoothingBicubicSplineInterpolator" class
      2. create a "BicubicSplineInterpolator" class (similar to the above class but with the useless code removed)
      3. remove the "SmoothingBicubicSplineInterpolatorTest" class
      4. add a "BicubicSplineInterpolatorTest" with essentially the same contents as the above one

      Then I would also add a new "SmoothingPolynomialBicubicSplineInterpolator" where I used the "PolynomialFitter" class to smooth the input data along both dimensions before the interpolating function is computed.

      Does someone object to these changes?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              erans Gilles
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: