[MATH-3] [math] Corrections to Constructor Fraction(double)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed

Environment

Operating System: other
Platform: All

• Bugzilla Id: 35434
• Assignee: Unassigned
• Reporter: Jörg Weimar
• Created: 20/Jun/05 21:14
• Updated: 23/Jul/12 23:24
• Resolved: 23/Apr/09 02:26

Description

The constructor for Fraction fails for doubles which are almost integer.

examples should be inserted in th etest case:

public void testConstructorDouble() {
try

{ ..... assertFraction(0, 1, new Fraction(0.00000000000001)); assertFraction(2, 5, new Fraction(0.40000000000001)); assertFraction(15, 1, new Fraction(15.0000000000001)); }

catch (ConvergenceException ex)

{ fail(ex.getMessage()); }

}

The fix for this problem is to include the following code in the constructor:

int n = 0;
boolean stop = false;

// check for (almost) integer arguments, which should not go
// to iterations.
if (Math.abs(a0 - value)<epsilon)

{ this.numerator = a0; this.denominator = 1; return; }

do {
++n;