[MATH-1658] ConvergenceChecker should implement OptimizationData

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0-beta1
• Component/s: legacy
• difficulty-level: Easy
• Assignee: Unassigned
• Reporter: François Laferrière
• Created: 31/Mar/23 13:05
• Updated: 29/Jun/23 21:57
• Resolved: 29/Jun/23 21:57

Description

It is a bit peculiar that with BaseOptimizer, ConvergenceChecker can be passed only in constructor.

It should be possible to change ConvergenceChecker at any other time.

Further it is a bit strange that the constructor do not accept other OptimizationData.

In my use cases, I need to create an optimizer once with complex OptimizationData and reuse it many time with very few changes (including changing the ConvergenceChecker).

So, I suggest that

• ConvergenceChecker implements OptimizationData.
• protected BaseOptimizer(ConvergenceChecker<PAIR> checker) is replaced by protected BaseOptimizer(OptimizationData... optData) 

Doing so is compatible with existing code and provide much more flexibility.