[MATH-1647] HaltonSequenceGenerator.skipTo() not throwing proper NotPositiveException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.6.1
• Fix Version/s: 4.0
• difficulty-level: Easy
• Assignee: Unassigned
• Reporter: Elia Bertolina
• Created: 23/May/22 07:32
• Updated: 20/Aug/22 00:50
• Resolved: 20/Aug/22 00:50

Description

HaltonSequenceGenerator.skipTo(int index) does not throw a NotPositiveException when the parameter is negative.In the documentation it is stated that an NotPositiveException will be thrown if the parameter value is less than zero.

However, in this test case:

public class HaltonSequenceGenerator_Test{
    public void test() throws Throwable{
        HaltonSequenceGenerator haltonSequenceGenerator = new 
        HaltonSequenceGenerator(1);
        try {
            double[] doubleArray =
            haltonSequenceGenerator.skipTo((-4584));
            org.junit.Assert.fail();
        } catch 
        (org.apache.commons.math3.exception.NotPositiveException e){
        //NotPositiveException caught and test successful        
        }    
    }
} 

The int parameter is negative and a NotPositiveException should be thrown, however the method executes normally, and test case fails.