[MATH-1354] Easy conversion from BigDecimal to BigFraction

• Type: Wish
• Status: Resolved
• Priority: Major
• Resolution: Won't Do
• Fix Version/s: 4.0
• Labels: commons-numbers
• Assignee: Unassigned
• Reporter: Dobes Vandermeer
• Created: 31/Mar/16 17:37
• Updated: 01/May/17 23:49
• Resolved: 01/May/17 23:49

Description

Users of BigFraction might also be working with BigDecimal. Here's a simple way to convert BigDecimal to BigFraction:

    public static BigFraction bigDecimalToBigFraction(BigDecimal bd) {
        int scale = bd.scale();

        // If scale >= 0 then the value is bd.unscaledValue() / 10^scale
        if(scale >= 0)
            return new BigFraction(bd.unscaledValue(), BigInteger.TEN.pow(scale));
        // If scale < 0 then the value is bd.unscaledValue() * 10^-scale
        return new BigFraction(bd.unscaledValue().multiply(BigInteger.TEN.pow(-scale)));
    }

It might be nice to have this incorporated into the BigFraction class as a constructor.

Issue Links

• is superceded by: NUMBERS-32 MATH-1354 (fraction)