[MATH-1261] Overflow checks in Fraction multiply(int) / divide(int)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0, 3.6
• Assignee: Unassigned
• Reporter: Osamu Ikeuchi
• Created: 20/Aug/15 12:47
• Updated: 25/Jan/16 20:28
• Resolved: 20/Aug/15 22:31

Description

The member methods multiply(int) / divide(int) in the class org.apache.commons.math3.fraction.Fraction do not have overflow checks.

return new Fraction(numerator * i, denominator);

should be

return new Fraction(ArithmeticUtils.mulAndCheck(numerator, i), denominator);

or, considering the case gcd(i, denominator) > 1,

return multiply(new Fraction(i));