[MATH-1029] Creating BigFraction objects is not consistent for negative/positive values

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.3
• Assignee: Thomas Neidhart
• Reporter: Thomas Neidhart
• Created: 31/Aug/13 19:48
• Updated: 19/May/14 15:13
• Resolved: 17/Oct/13 21:13

Description

Creating a BigFraction object for large integer values will return different results whether the argument is positive or negative:

  BigFraction f1 = new BigFraction(-1e10, 1000); -> will return a fraction with a numerator of -1e10 and denominator of 1
  BigFraction f2 = new BigFraction(1e10, 1000); -> will throw a FractionConversionException

the problem is in the check for overflow, it is not done on the absolute value of the argument, also it should be done only after the check if the argument is actually an integer.