Commons Math
  1. Commons Math
  2. MATH-1018

Add constructor to remove inverseCumAccuracy

    Details

    • Type: Wish Wish
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3
    • Labels:
      None

      Description

      Add constructors that don't require inverseCumAccuracy for subclasses of AbstractRealDistribution.

        Activity

        Hide
        Thomas Neidhart added a comment -

        Added in r1519842.

        Thanks for the report.

        Show
        Thomas Neidhart added a comment - Added in r1519842. Thanks for the report.
        Hide
        Ajo Fod added a comment -

        That is right.

        Show
        Ajo Fod added a comment - That is right.
        Hide
        Thomas Neidhart added a comment -

        So if I understand you correctly, you want new constructors for subclasses of AbstractRealDistribution, e.g. NormalDistribution, which allow to specify a RandomGenerator and the necessary distribution parameters, but without the inverseCumAccuracy (using the default one):

        NOW:
            public NormalDistribution(RandomGenerator rng, double mean, double sd, double inverseCumAccuracy)
        NEW:
            public NormalDistribution(RandomGenerator rng, double mean, double sd)
        
        Show
        Thomas Neidhart added a comment - So if I understand you correctly, you want new constructors for subclasses of AbstractRealDistribution, e.g. NormalDistribution, which allow to specify a RandomGenerator and the necessary distribution parameters, but without the inverseCumAccuracy (using the default one): NOW: public NormalDistribution(RandomGenerator rng, double mean, double sd, double inverseCumAccuracy) NEW: public NormalDistribution(RandomGenerator rng, double mean, double sd)
        Hide
        Ajo Fod added a comment -

        Many of the sub classes that inherit from this class require the inverseCumAccuracy with the constructors that allow definition of a random path through RandomGenerator. It's pretty common use case to want to define only the random generator and the parameters of the distribution.

        Show
        Ajo Fod added a comment - Many of the sub classes that inherit from this class require the inverseCumAccuracy with the constructors that allow definition of a random path through RandomGenerator. It's pretty common use case to want to define only the random generator and the parameters of the distribution.
        Hide
        Thomas Neidhart added a comment -

        Can you clarify what you want to change?
        AbstractRealDistribution does not have a constructor requiring a parameter "inverseCumAccuracy".

        Show
        Thomas Neidhart added a comment - Can you clarify what you want to change? AbstractRealDistribution does not have a constructor requiring a parameter "inverseCumAccuracy".

          People

          • Assignee:
            Unassigned
            Reporter:
            Ajo Fod
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development