[MASSEMBLY-726] Fix artifact inclusion/exclusion filtering

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.2
• Assignee: Kristian Rosenvold
• Reporter: Kristian Rosenvold
• Created: 31/Oct/14 01:50
• Updated: 11/Nov/14 02:12
• Resolved: 09/Nov/14 06:44

Description

Artifact filtering is implemented in several places and at different layers, and is rich with inconsistencies. Some code tries to filter based on "source" artifact while the (correct) approach is to implement on target filename; avoid duplicate files being added to the archive under the same name. If the user wants to add the same file under different names, we should not care.

The entire class AssemblyProxyArchiver should basically be removed (there is a DryRunArchiver in plexus that can be used for dry runs). The other logic in this class is faulty duplication control and/or workarounds that I suspect have been added as symptomatic stopgaps for MASSEMBLY-725

Issue Links

• is depended upon by: MASSEMBLY-583 DependencySet elements appear not to be able to target the same outputDirectory
• is related to: MASSEMBLY-725 Fix phase ordering
• relates to: MASSEMBLY-597 Duplicate files added to archive when present in both dependencyset and fileset of the same assembly