Maven Assembly Plugin
  1. Maven Assembly Plugin
  2. MASSEMBLY-184

components are not interpolated - i.e., ${params} are not substituted

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2-beta-2
    • Component/s: None
    • Labels:
      None
    • Environment:
      all

      Description

      Components are no more than the extension of an Assembly. As such, they ought to also be interpolated. Why is there the current restriction that the $

      {param} will be replaced when it appears in an Assembly, but not if it appears in a Component?

      Without interpolating Components, it will not be possible to refactor a component out of an assembly if it contains a ${param}

      to be replaced.

      Attached is a diff with the code change and a test case. The change: the call to merge components into the assembly now appears before assembly's interpolation in the DefaultAssemblyReader, not after.

      Regards,
      John

      1. CompInterpol.diff
        3 kB
        John J. Franey

        Issue Links

          Activity

          John J. Franey created issue -
          Hide
          Mark Reynolds added a comment -

          The component feature is not useful for my project without this fix.

          Show
          Mark Reynolds added a comment - The component feature is not useful for my project without this fix.
          John Casey made changes -
          Field Original Value New Value
          Assignee John Casey [ jdcasey ]
          John Casey made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          John Casey made changes -
          Fix Version/s 2.2-beta-2 [ 13507 ]
          Hide
          John Casey added a comment -

          Applied. Great patch, thanks.

          Show
          John Casey added a comment - Applied. Great patch, thanks.
          John Casey made changes -
          Status In Progress [ 3 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          John Casey made changes -
          Fix Version/s 2.2-beta-2 [ 14027 ]
          Fix Version/s 2.2-beta-3 [ 13507 ]
          Trevor Pounds made changes -
          Link This issue duplicates MASSEMBLY-139 [ MASSEMBLY-139 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 09:09:00 UTC 2015 [ 1428224940639 ]
          Mark Thomas made changes -
          Workflow jira [ 12717137 ] Default workflow, editable Closed status [ 12760900 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 22:33:31 UTC 2015 [ 1428273211083 ]
          Mark Thomas made changes -
          Workflow jira [ 12954697 ] Default workflow, editable Closed status [ 12992061 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          177d 21h 25m 1 John Casey 15/Aug/07 18:36
          In Progress In Progress Closed Closed
          12m 53s 1 John Casey 15/Aug/07 18:49

            People

            • Assignee:
              John Casey
              Reporter:
              John J. Franey
            • Votes:
              3 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development