[MARTIFACT-54] In multi-module projects check-buildplan fails on project.build.outputTimestamp

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.1
• Component/s: artifact:check-buildplan
• Labels: pull-request-available
• Assignee: Herve Boutemy
• Reporter: Niels Basjes
• Created: 01/Nov/23 12:48
• Updated: 30/Mar/24 01:35
• Resolved: 01/Nov/23 20:19

Description

Reproduce:

In an empty directory create a pom.xml with

<?xml version="1.0"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <packaging>pom</packaging>
  <groupId>nl.basjes.maven</groupId>
  <artifactId>parent</artifactId>
  <version>0.0.1-SNAPSHOT</version>
  <properties>
    <project.build.outputTimestamp>2011-11-11T11:11:11Z</project.build.outputTimestamp>
  </properties>
  <modules>
    <module>child</module>
  </modules>
</project>

create a subdirectory child and create the file child/pom.xml with

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <parent>
    <groupId>nl.basjes.maven</groupId>
    <artifactId>parent</artifactId>
    <version>0.0.1-SNAPSHOT</version>
  </parent>
  <artifactId>child</artifactId>
</project>

Now run the 3.4.1 version of the plugin using maven 3.9.4 on Linux under Java 17:

$ mvn org.apache.maven.plugins:maven-artifact-plugin:3.4.1:check-buildplan 

Summary of the output:

[INFO] parent ............................................. SUCCESS [  0.228 s]
[INFO] child .............................................. SUCCESS [  0.042 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

Now repeat the same with the 3.5.0 version of the plugin:

$ mvn org.apache.maven.plugins:maven-artifact-plugin:3.5.0:check-buildplan

Summary of the output:

[INFO] Reactor Build Order:
[INFO] 
[INFO] parent                                                             [pom]
[INFO] child                                                              [jar]
...
[INFO] -----------------------< nl.basjes.maven:child >------------------------
[INFO] Building child 0.0.1-SNAPSHOT                                      [2/2]
[INFO]   from child/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- artifact:3.5.0:check-buildplan (default-cli) @ child ---
[ERROR] project.build.outputTimestamp property should not be inherited but defined in POM /home/nbasjes/workspace/Prive/BugReports/CheckBuildPlan/child/pom.xml
...
[INFO] BUILD FAILURE

Issue Links

• fixes: MARTIFACT-59 artifact plugin should tolerate injected project.build.outputTimestamp
• is superceded by: MARTIFACT-53 improve message when outputTimestamp not defined in reactor: WARN only
• links to: GitHub Pull Request #27