Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: client, jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Adds an API Cluster#getJobHistoryUrl(JobID jobId) to get the history url for a given job id. The API does not check for the validity of job id or existence of the history file. It just constructs the url based on history folder, job id and the current user.
      Show
      Adds an API Cluster#getJobHistoryUrl(JobID jobId) to get the history url for a given job id. The API does not check for the validity of job id or existence of the history file. It just constructs the url based on history folder, job id and the current user.

      Description

      MAPREDUCE-817 added an API to get history url in RunningJob. Similar API should be added in job client to get the history file given a job id. Something like:
      String getHistoryFile(JobId jobid);

      1. 975_v3.patch
        10 kB
        Sharad Agarwal
      2. 975_v2.patch
        10 kB
        Sharad Agarwal
      3. 975_v1.patch
        11 kB
        Sharad Agarwal

        Issue Links

          Activity

          Sharad Agarwal created issue -
          Sharad Agarwal made changes -
          Field Original Value New Value
          Link This issue is blocked by MAPREDUCE-777 [ MAPREDUCE-777 ]
          Sharad Agarwal made changes -
          Link This issue is blocked by MAPREDUCE-157 [ MAPREDUCE-157 ]
          Sharad Agarwal made changes -
          Summary Add an API in job client to get the history file url Add an API in job client to get the history file url for a given job id
          Sharad Agarwal made changes -
          Parent MAPREDUCE-863 [ 12432997 ]
          Issue Type Improvement [ 4 ] Sub-task [ 7 ]
          Sharad Agarwal made changes -
          Assignee Sharad Agarwal [ sharadag ]
          Hide
          Sharad Agarwal added a comment -

          Patch on top of MAPREDUCE-777 patch. This patch also removes some redundant methods from JobHistory, used only by the test case.

          Show
          Sharad Agarwal added a comment - Patch on top of MAPREDUCE-777 patch. This patch also removes some redundant methods from JobHistory, used only by the test case.
          Sharad Agarwal made changes -
          Attachment 975_v1.patch [ 12419876 ]
          Sharad Agarwal made changes -
          Fix Version/s 0.21.0 [ 12314045 ]
          Component/s jobtracker [ 12312907 ]
          Hide
          Sharad Agarwal added a comment -

          Updated to trunk

          Show
          Sharad Agarwal added a comment - Updated to trunk
          Sharad Agarwal made changes -
          Attachment 975_v2.patch [ 12419987 ]
          Sharad Agarwal made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Jothi Padmanabhan added a comment -

          Looks good. Minor nits

          1. JobTracker.getJobHistoryDir does not need to throw the exceptions
          2. It would be good to add an assert for null at the end of getDoneFile
          Show
          Jothi Padmanabhan added a comment - Looks good. Minor nits JobTracker.getJobHistoryDir does not need to throw the exceptions It would be good to add an assert for null at the end of getDoneFile
          Sharad Agarwal made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Sharad Agarwal added a comment -

          Incorporated Jothi's comments.

          Show
          Sharad Agarwal added a comment - Incorporated Jothi's comments.
          Sharad Agarwal made changes -
          Attachment 975_v3.patch [ 12419996 ]
          Sharad Agarwal made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Sharad Agarwal added a comment -

          test patch passed:

           +1 overall.
               [exec]
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec]
               [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
               [exec]
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec]
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec]
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec]
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
          Show
          Sharad Agarwal added a comment - test patch passed: +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          Hide
          Jothi Padmanabhan added a comment -

          +1

          Show
          Jothi Padmanabhan added a comment - +1
          Hide
          Sharad Agarwal added a comment -

          All core and contrib tests passed.

          Show
          Sharad Agarwal added a comment - All core and contrib tests passed.
          Hide
          Sharad Agarwal added a comment -

          I just committed this.

          Show
          Sharad Agarwal added a comment - I just committed this.
          Sharad Agarwal made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #53 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/53/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #53 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/53/ )
          Hide
          Nigel Daley added a comment -

          At a quick glance, it seems obvious that this is missing a test case for a bad jobid. Probably other test cases missing too. Can you correct this?

          Show
          Nigel Daley added a comment - At a quick glance, it seems obvious that this is missing a test case for a bad jobid. Probably other test cases missing too. Can you correct this?
          Hide
          Sharad Agarwal added a comment -

          it seems obvious that this is missing a test case for a bad jobid.

          The api doesn't check for the validity of the jobid. It just constructs the url based on the jobid passed. The javadoc of the api says that the history file may or may not be present depending on the job state.

          Show
          Sharad Agarwal added a comment - it seems obvious that this is missing a test case for a bad jobid. The api doesn't check for the validity of the jobid. It just constructs the url based on the jobid passed. The javadoc of the api says that the history file may or may not be present depending on the job state.
          Sharad Agarwal made changes -
          Release Note Adds an API Cluster#getJobHistoryUrl(JobID jobId) to get the history url for a given job id. The API does not check for the validity of job id or existence of the history file. It just constructs the url based on history folder, job id and the current user.
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Sharad Agarwal
              Reporter:
              Sharad Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development