Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-963

mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Deprecate o.a.h.mapred.FileAlreadyExistsException and replace it with o.a.h.fs.FileAlreadyExistsException.

      Description

      We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
      Mapred's one should be deprecated.

      1. MAPREDUCE-963.patch
        2 kB
        Boris Shkolnik
      2. MAPREDUCE-963.patch
        4 kB
        Boris Shkolnik

        Issue Links

          Activity

          Boris Shkolnik created issue -
          Boris Shkolnik made changes -
          Field Original Value New Value
          Attachment MAPREDUCE-963.patch [ 12418981 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Incompatible change] [Incompatible change, Reviewed]
          Assignee Boris Shkolnik [ boryas ]
          Hide
          Arun C Murthy added a comment -

          We should updated all references of org.apache.hadoop.mapred.FileAlreadyExistsException to use the one in common. E.g. Streaming, test-cases etc.

          Show
          Arun C Murthy added a comment - We should updated all references of org.apache.hadoop.mapred.FileAlreadyExistsException to use the one in common. E.g. Streaming, test-cases etc.
          Arun C Murthy made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Boris Shkolnik added a comment -

          Good point. I thought I got all of them. Turns out Eclipse missed some of them.

          Show
          Boris Shkolnik added a comment - Good point. I thought I got all of them. Turns out Eclipse missed some of them.
          Boris Shkolnik made changes -
          Attachment MAPREDUCE-963.patch [ 12418996 ]
          Boris Shkolnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Boris Shkolnik made changes -
          Link This issue is part of HDFS-303 [ HDFS-303 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12418981/MAPREDUCE-963.patch
          against trunk revision 812546.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418981/MAPREDUCE-963.patch against trunk revision 812546. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12418996/MAPREDUCE-963.patch
          against trunk revision 812546.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418996/MAPREDUCE-963.patch against trunk revision 812546. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/console This message is automatically generated.
          Tsz Wo Nicholas Sze made changes -
          Release Note Deprecate o.a.h.mapred.FileAlreadyExistsException and replace it with o.a.h.fs.FileAlreadyExistsException.
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          Fix Version/s 0.21.0 [ 12314045 ]
          Affects Version/s 0.21.0 [ 12314045 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Boris!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Boris!
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #25 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/25/)
          . Deprecate o.a.h.mapred.FileAlreadyExistsException and replace it with o.a.h.fs.FileAlreadyExistsException. Contributed by Boris Shkolnik

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #25 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/25/ ) . Deprecate o.a.h.mapred.FileAlreadyExistsException and replace it with o.a.h.fs.FileAlreadyExistsException. Contributed by Boris Shkolnik
          Hide
          Chris Douglas added a comment -

          Sorry to be late to this issue, but mapred.FileAlreadyExistsException should extend fs.FileAlreadyExistsException, so 0.21 FAEExceptions won't pass through catches written against earlier versions.

          Show
          Chris Douglas added a comment - Sorry to be late to this issue, but mapred.FileAlreadyExistsException should extend fs.FileAlreadyExistsException, so 0.21 FAEExceptions won't pass through catches written against earlier versions.
          Hide
          Chris Douglas added a comment -

          Wait... scratch that; I have it backwards. We lose, nevermind.

          Show
          Chris Douglas added a comment - Wait... scratch that; I have it backwards. We lose, nevermind.
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          37m 53s 1 Arun C Murthy 09/Sep/09 00:12
          Open Open Patch Available Patch Available
          3h 42m 2 Boris Shkolnik 09/Sep/09 00:43
          Patch Available Patch Available Resolved Resolved
          19h 6m 1 Tsz Wo Nicholas Sze 09/Sep/09 19:49
          Resolved Resolved Closed Closed
          349d 2h 27m 1 Tom White 24/Aug/10 22:17

            People

            • Assignee:
              Boris Shkolnik
              Reporter:
              Boris Shkolnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development