Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-912

apache license header missing for some java files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The following files do not have apache license header :
      src/java/org/apache/hadoop/mapred/lib/db/DBWritable.java
      src/java/org/apache/hadoop/mapreduce/Counters.java
      src/test/mapred/org/apache/hadoop/mapred/lib/db/TestConstructQuery.java
      src/examples/org/apache/hadoop/examples/WordCount.java

      1. 912.patch
        17 kB
        Chad Metcalf

        Activity

        Hide
        Simon Willnauer added a comment -

        i remember that there are some scripts to add licence headers to source files somewhere at https://svn.apache.org/repos/private/committers/tools/ - this might be handy if there are more files with a missing header.

        Show
        Simon Willnauer added a comment - i remember that there are some scripts to add licence headers to source files somewhere at https://svn.apache.org/repos/private/committers/tools/ - this might be handy if there are more files with a missing header.
        Hide
        Chad Metcalf added a comment -

        Patch for all Java files that standardizes on one header. There are more files touched then just the one's called out. And some of them have headers. But this patch fixes all headers to be identical (side effect of the Eclipse RelEng tool). In looking at the src

        /**

        • Licensed to the Apache Software Foundation (ASF) under one
        • or more contributor license agreements. See the NOTICE file
        • distributed with this work for additional information
        • regarding copyright ownership. The ASF licenses this file
        • to you under the Apache License, Version 2.0 (the
        • "License"); you may not use this file except in compliance
        • with the License. You may obtain a copy of the License at
          *
        • http://www.apache.org/licenses/LICENSE-2.0
          *
        • Unless required by applicable law or agreed to in writing, software
        • distributed under the License is distributed on an "AS IS" BASIS,
        • WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        • See the License for the specific language governing permissions and
        • limitations under the License.
          */

        Seemed like the default so its the template I used.

        Show
        Chad Metcalf added a comment - Patch for all Java files that standardizes on one header. There are more files touched then just the one's called out. And some of them have headers. But this patch fixes all headers to be identical (side effect of the Eclipse RelEng tool). In looking at the src /** Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at * http://www.apache.org/licenses/LICENSE-2.0 * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ Seemed like the default so its the template I used.
        Hide
        Chad Metcalf added a comment -

        SImple patch to fix headers

        Show
        Chad Metcalf added a comment - SImple patch to fix headers
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12417911/912.patch
        against trunk revision 815628.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/39/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/39/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/39/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/39/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12417911/912.patch against trunk revision 815628. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/39/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/39/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/39/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/39/console This message is automatically generated.
        Hide
        Chris Douglas added a comment -

        +1

        I committed this. Thanks, Chad!

        Show
        Chris Douglas added a comment - +1 I committed this. Thanks, Chad!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #58 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/58/)
        . Add and standardize Apache license headers. Contributed by Chad Metcalf

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #58 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/58/ ) . Add and standardize Apache license headers. Contributed by Chad Metcalf

          People

          • Assignee:
            Chad Metcalf
            Reporter:
            Amareshwari Sriramadasu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development