Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-847

Adding Apache License Headers and reduce releaseaudit warnings to zero

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None

      Description

      [rat:report] Summary
      [rat:report] -------
      [rat:report] Notes: 14
      [rat:report] Binaries: 178
      [rat:report] Archives: 49
      [rat:report] Standards: 1364
      [rat:report]
      [rat:report] Apache Licensed: 1152
      [rat:report] Generated Documents: 9
      [rat:report]
      [rat:report] JavaDocs are generated and so license header is optional
      [rat:report] Generated files do not required license headers
      [rat:report]
      [rat:report] 203 Unknown Licenses

      1. MAPREDUCE-847-v2.PATCH
        85 kB
        Giridharan Kesavan
      2. MAPREDUCE-847-v1.PATCH
        84 kB
        Giridharan Kesavan
      3. MAPREDUCE-847.PATCH
        87 kB
        Giridharan Kesavan

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #225 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/225/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #225 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/225/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #208 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/208/)
        . Fix Releaseaudit warning count to zero. Contributed by Giridharan Kesavan

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #208 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/208/ ) . Fix Releaseaudit warning count to zero. Contributed by Giridharan Kesavan
        Hide
        Giridharan Kesavan added a comment -

        test fails is unrelated to the patch, build on my local box with this patch is successful.

        Show
        Giridharan Kesavan added a comment - test fails is unrelated to the patch, build on my local box with this patch is successful.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12430400/MAPREDUCE-847-v2.PATCH
        against trunk revision 899501.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 29 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/391/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/391/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/391/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/391/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430400/MAPREDUCE-847-v2.PATCH against trunk revision 899501. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 29 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/391/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/391/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/391/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/391/console This message is automatically generated.
        Hide
        Giridharan Kesavan added a comment -

        updated patch with comments.

        Show
        Giridharan Kesavan added a comment - updated patch with comments.
        Hide
        Chris Douglas added a comment -
        • This should exclude src/test/tools/data/rumen, perhaps even src/test/tools/data ; some of the files are compressed in trunk (MAPREDUCE-1077)
        • libhdfs may be moved to the HDFS project soon (MAPREDUCE-665); the excludes should be removed when/if it does

        Other than that, this looks good

        Show
        Chris Douglas added a comment - This should exclude src/test/tools/data/rumen , perhaps even src/test/tools/data ; some of the files are compressed in trunk ( MAPREDUCE-1077 ) libhdfs may be moved to the HDFS project soon ( MAPREDUCE-665 ); the excludes should be removed when/if it does Other than that, this looks good
        Hide
        Lee Tucker added a comment -

        The patch is clearer now about which C++ we're excluding and why.

        Show
        Lee Tucker added a comment - The patch is clearer now about which C++ we're excluding and why.
        Hide
        Giridharan Kesavan added a comment -

        After off-line discussion with Lee uploading an updated patch

        Show
        Giridharan Kesavan added a comment - After off-line discussion with Lee uploading an updated patch
        Hide
        Giridharan Kesavan added a comment -

        There are too many c++ make related conf. files in there which already has GNU license headers added to them.
        So I excluded them from being audited.

        Show
        Giridharan Kesavan added a comment - There are too many c++ make related conf. files in there which already has GNU license headers added to them. So I excluded them from being audited.
        Hide
        Nigel Daley added a comment -

        Giri, can you explain these 2 excludes?

        + <exclude name="src/c++/**"/>
        + <exclude name="src/examples/pipes/*"/>

        The rest looks good.

        Show
        Nigel Daley added a comment - Giri, can you explain these 2 excludes? + <exclude name="src/c++/**"/> + <exclude name="src/examples/pipes/*"/> The rest looks good.
        Hide
        Giridharan Kesavan added a comment -

        core test failure is tracked in MAPREDUCE-1029

        With this patch, releaseaudit warnings for MR is reduced to 1. (we have an empty java file src/java/org/apache/hadoop/mapred/JobSubmissionProtocol.java)

        Nigel,
        Could you review this patch?
        thanks

        Show
        Giridharan Kesavan added a comment - core test failure is tracked in MAPREDUCE-1029 With this patch, releaseaudit warnings for MR is reduced to 1. (we have an empty java file src/java/org/apache/hadoop/mapred/JobSubmissionProtocol.java) Nigel, Could you review this patch? thanks
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12420774/MAPREDUCE-847.PATCH
        against trunk revision 819740.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 26 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/137/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/137/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/137/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/137/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420774/MAPREDUCE-847.PATCH against trunk revision 819740. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 26 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/137/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/137/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/137/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/137/console This message is automatically generated.

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Giridharan Kesavan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development