Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-834

When TaskTracker config use old memory management values its memory monitoring is diabled.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      The tasktracker's startup code was modified to use deprecated memory management configuration variables, when specified, and enable memory monitoring of tasks.

      Description

      TaskTracker memory config values -:
      mapred.tasktracker.vmem.reserved=8589934592
      mapred.task.default.maxvmem=2147483648
      mapred.task.limit.maxvmem=4294967296
      mapred.tasktracker.pmem.reserved=2147483648
      TaskTracker start as -:
      2009-08-05 12:39:03,308 WARN org.apache.hadoop.mapred.TaskTracker: The variable mapred.tasktracker.vmem.reserved is no longer used
      2009-08-05 12:39:03,308 WARN org.apache.hadoop.mapred.TaskTracker: The variable mapred.tasktracker.pmem.reserved is no longer used
      2009-08-05 12:39:03,308 WARN org.apache.hadoop.mapred.TaskTracker: The variable mapred.task.default.maxvmem is no longer used
      2009-08-05 12:39:03,308 WARN org.apache.hadoop.mapred.TaskTracker: The variable mapred.task.limit.maxvmem is no longer used
      2009-08-05 12:39:03,308 INFO org.apache.hadoop.mapred.TaskTracker: Starting thread: Map-events fetcher for all reduce tasks on <tracker_name>
      2009-08-05 12:39:03,309 INFO org.apache.hadoop.mapred.TaskTracker: Using MemoryCalculatorPlugin : org.apache.hadoop.util.LinuxMemoryCalculatorPlugin@19be4777
      2009-08-05 12:39:03,311 WARN org.apache.hadoop.mapred.TaskTracker: TaskTracker's totalMemoryAllottedForTasks is -1. TaskMemoryManager is disabled.

      1. mapreduce-834-ydist.patch
        0.7 kB
        Sreekanth Ramakrishnan
      2. mapreduce-834-4.patch
        4 kB
        Sreekanth Ramakrishnan
      3. mapreduce-834-3.patch
        4 kB
        Sreekanth Ramakrishnan
      4. mapreduce-834-2.patch
        4 kB
        Sreekanth Ramakrishnan
      5. mapreduce-834-1.patch
        4 kB
        Sreekanth Ramakrishnan
      6. mapred-834-20.patch
        4 kB
        Sreekanth Ramakrishnan

        Activity

        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching a file which enables memory monitoring if only the old configuration keys are present in the configuration file.

        Show
        Sreekanth Ramakrishnan added a comment - Attaching a file which enables memory monitoring if only the old configuration keys are present in the configuration file.
        Hide
        Hemanth Yamijala added a comment -

        Few comments:

        • Memory allotted for slot based on old configuration should not be based on getMaxVirtualMemoryForTask(), but on JobConf.MAPRED_TASK_DEFAULT_MAXVMEM_PROPERTY. Also note that this value will be in bytes, while the system maintains everything else in MB. So, it should be converted to MB.
        • testTaskMemoryMonitoringWithDeprecatedConfiguration should also set the TT configuration for JobConf.MAPRED_TASK_DEFAULT_MAXVMEM_PROPERTY in bytes instead of MAPRED_TASK_MAXVMEM_PROPERTY.
        Show
        Hemanth Yamijala added a comment - Few comments: Memory allotted for slot based on old configuration should not be based on getMaxVirtualMemoryForTask(), but on JobConf.MAPRED_TASK_DEFAULT_MAXVMEM_PROPERTY. Also note that this value will be in bytes, while the system maintains everything else in MB. So, it should be converted to MB. testTaskMemoryMonitoringWithDeprecatedConfiguration should also set the TT configuration for JobConf.MAPRED_TASK_DEFAULT_MAXVMEM_PROPERTY in bytes instead of MAPRED_TASK_MAXVMEM_PROPERTY.
        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching patch fixing using the correct key and converting the same to MB while allotting total memory alloted to the tasks.

        Show
        Sreekanth Ramakrishnan added a comment - Attaching patch fixing using the correct key and converting the same to MB while allotting total memory alloted to the tasks.
        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching file fixing an issue found during internal testing. Modified test case and code.

        Show
        Sreekanth Ramakrishnan added a comment - Attaching file fixing an issue found during internal testing. Modified test case and code.
        Hide
        Sreekanth Ramakrishnan added a comment -

        Removing an unused variable from the test case.

        Show
        Sreekanth Ramakrishnan added a comment - Removing an unused variable from the test case.
        Hide
        Hemanth Yamijala added a comment -

        Last patch looks fine to me. +1. Running through Hudson. Let's wait for the hudson run before uploading the 20 patch.

        Show
        Hemanth Yamijala added a comment - Last patch looks fine to me. +1. Running through Hudson. Let's wait for the hudson run before uploading the 20 patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12417108/mapreduce-834-4.patch
        against trunk revision 806065.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/496/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/496/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/496/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/496/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12417108/mapreduce-834-4.patch against trunk revision 806065. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/496/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/496/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/496/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/496/console This message is automatically generated.
        Hide
        Sreekanth Ramakrishnan added a comment -

        The patch does not change any part on JobTracker or streaming api's.

        The issue with TestRecoveryManager timing out is reported on MAPREDUCE-880 and the streaming test case failures are also a known reported issue on hudson.

        Show
        Sreekanth Ramakrishnan added a comment - The patch does not change any part on JobTracker or streaming api's. The issue with TestRecoveryManager timing out is reported on MAPREDUCE-880 and the streaming test case failures are also a known reported issue on hudson.
        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching patch for branch 20.

        Show
        Sreekanth Ramakrishnan added a comment - Attaching patch for branch 20.
        Hide
        Hemanth Yamijala added a comment -

        I just committed this to trunk and branch 0.20. Thanks, Sreekanth !

        Show
        Hemanth Yamijala added a comment - I just committed this to trunk and branch 0.20. Thanks, Sreekanth !
        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching Yahoo! distribution patch.

        Show
        Sreekanth Ramakrishnan added a comment - Attaching Yahoo! distribution patch.

          People

          • Assignee:
            Sreekanth Ramakrishnan
            Reporter:
            Karam Singh
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development