Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-785

Refactor TestReduceFetchFromPartialMem into a separate test

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Moves TestReduceFetchFromPartialMem out of TestReduceFetch into a separate test to enable it to be included in the commit-tests target.

      Description

      The rationale behind doing this is to enable this test alone to be included in the commit-tests target

      1. mapred-785.patch
        20 kB
        Jothi Padmanabhan

        Issue Links

          Activity

          Hide
          Jothi Padmanabhan added a comment -

          Patch that splits the tests. Thanks Konstantin for help with this patch

          Show
          Jothi Padmanabhan added a comment - Patch that splits the tests. Thanks Konstantin for help with this patch
          Hide
          Chris Douglas added a comment -

          +1 Looks good. The refactored tests passed with the expected semantics.

               [exec] +1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec] 
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          

          I committed this. Thanks, Jothi!

          Show
          Chris Douglas added a comment - +1 Looks good. The refactored tests passed with the expected semantics. [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. I committed this. Thanks, Jothi!

            People

            • Assignee:
              Jothi Padmanabhan
              Reporter:
              Jothi Padmanabhan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development