Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-7379

RMContainerRequestor#makeRemoteRequest has confusing log message

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      org.apache.hadoop.mapreduce.v2.app.rm.RMContainerRequestor#makeRemoteRequest has this log:

      if (ask.size() > 0 || release.size() > 0) {
            LOG.info("getResources() for " + applicationId + ":" + " ask="
                + ask.size() + " release= " + release.size() + " newContainers="
                + allocateResponse.getAllocatedContainers().size()
                + " finishedContainers=" + numCompletedContainers
                + " resourcelimit=" + availableResources + " knownNMs="
                + clusterNmCount);
          }
      

      The reason why "getResources()" is printed because org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator#getResources invokes makeRemoteRequest. This is not too informative and error-prone as name of getResources could change over time and the log will be outdated. Moreover, it's not a good idea to print a method name from a method below the current one in the stack.

      Attachments

        1. YARN-9355.001.patch
          1 kB
          Umesh Mittal
        2. YARN-9355.002.patch
          2 kB
          Umesh Mittal

        Issue Links

          Activity

            People

              groot Ashutosh Gupta
              snemeth Szilard Nemeth
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 40m
                  1h 40m