[MAPREDUCE-7310] Clear the fileMap in JHEventHandlerForSigtermTest

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.4.0, 3.3.1, 3.2.3
• Component/s: test
• Labels: pull-request-available
• Hadoop Flags: Reviewed
• Assignee: Zhengxi Li
• Reporter: Zhengxi Li
• Created: 29/Nov/20 23:11
• Updated: 10/Jun/21 08:10
• Resolved: 12/Jan/21 07:34

Description

The test 'org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality' is not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.

Details

Running `TestJobHistoryEventHandler.testSigTermedFunctionality` twice would result in the second run failing due to `NullPointerException`shown in the following:

 java.lang.NullPointerException
 at org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:460)
 at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
 at org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality(TestJobHistoryEventHandler.java:933)

The root cause of this is that running 'TestJobHistoryEventHandler.testSigTermedFunctionality' results in some entries to be added to the static 'JobHistoryEventHandler.fileMap'. The entries in the 'fileMap' are not cleaned up when the test is done, resulting in a NullPointerException in the second run as the stale object(added in the first run) in the 'fileMap' is accessed.

 

PR link: https://github.com/apache/hadoop/pull/2499

Issue Links

• links to: GitHub Pull Request #2499