[MAPREDUCE-7146] Review of RMCommunicator Class

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.2.0
• Component/s: mr-am
• Flags: Patch
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 28/Sep/18 01:44
• Updated: 28/Sep/18 15:47

Description

Various improvements to the RMCommunicator class.

 

• Use SLF4J parameterized logging
• Use switch statement instead of if-else statements
• Remove anti-pattern of "log and throw" (just throw)
• Use a flag to stop thread instead of an interrupt (it may be interrupting the heartbeat code and not the thread loop)
• The main thread loops performs loops on the heartbeat callback queue until the queue is empty.  It's technically possible that other threads could constantly put new callbacks into the queue and therefore the main thread never progresses past the callbacks.  Put a cap on the number of callbacks that will be processed in any iteration.