Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6965

QuasiMonteCarlo should use Time.monotonicNow for measuring durations

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: examples
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-14883.patch
      2 kB
      Chetna Chaudhari

      Issue Links

        Activity

        Hide
        chetna Chetna Chaudhari added a comment -

        Please review the patch.

        Show
        chetna Chetna Chaudhari added a comment - Please review the patch.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for the patch!

        +1 lgtm pending Jenkins

        Show
        jlowe Jason Lowe added a comment - Thanks for the patch! +1 lgtm pending Jenkins
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 414m 25s Docker failed to build yetus/hadoop:71bbb86.



        Subsystem Report/Notes
        JIRA Issue MAPREDUCE-6965
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888209/HADOOP-14883.patch
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7149/console
        Powered by Apache Yetus 0.5.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 414m 25s Docker failed to build yetus/hadoop:71bbb86. Subsystem Report/Notes JIRA Issue MAPREDUCE-6965 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888209/HADOOP-14883.patch Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7149/console Powered by Apache Yetus 0.5.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 15m 22s trunk passed
        +1 compile 0m 19s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 findbugs 0m 34s trunk passed
        +1 javadoc 0m 16s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 20s the patch passed
        +1 compile 0m 17s the patch passed
        +1 javac 0m 17s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 38s the patch passed
        +1 javadoc 0m 14s the patch passed
              Other Tests
        +1 unit 0m 31s hadoop-mapreduce-examples in the patch passed.
        +1 asflicense 0m 13s The patch does not generate ASF License warnings.
        20m 53s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue MAPREDUCE-6965
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888209/HADOOP-14883.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 56d173fe59d9 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e5e1851
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7150/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7150/console
        Powered by Apache Yetus 0.5.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 22s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 23s trunk passed +1 findbugs 0m 34s trunk passed +1 javadoc 0m 16s trunk passed       Patch Compile Tests +1 mvninstall 0m 20s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 14s the patch passed       Other Tests +1 unit 0m 31s hadoop-mapreduce-examples in the patch passed. +1 asflicense 0m 13s The patch does not generate ASF License warnings. 20m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue MAPREDUCE-6965 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888209/HADOOP-14883.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 56d173fe59d9 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e5e1851 Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7150/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7150/console Powered by Apache Yetus 0.5.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Chetna Chaudhari! I committed this to trunk, branch-3.0, and branch-2.

        Show
        jlowe Jason Lowe added a comment - Thanks, Chetna Chaudhari ! I committed this to trunk, branch-3.0, and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12946 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12946/)
        MAPREDUCE-6965. QuasiMonteCarlo should use Time.monotonicNow for (jlowe: rev 908d8e914ef55aca69cb8e725e62bda29d1073cc)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12946 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12946/ ) MAPREDUCE-6965 . QuasiMonteCarlo should use Time.monotonicNow for (jlowe: rev 908d8e914ef55aca69cb8e725e62bda29d1073cc) (edit) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Hide
        chetna Chetna Chaudhari added a comment -

        Thanks Jason Lowe for reviewing and committing the patch.

        Show
        chetna Chetna Chaudhari added a comment - Thanks Jason Lowe for reviewing and committing the patch.

          People

          • Assignee:
            chetna Chetna Chaudhari
            Reporter:
            chetna Chetna Chaudhari
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development