Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6964

BaileyBorweinPlouffe should use Time.monotonicNow for measuring durations

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: examples
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-14884.patch
      2 kB
      Chetna Chaudhari

      Issue Links

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 18m 2s trunk passed
        +1 compile 0m 24s trunk passed
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 0m 21s trunk passed
        +1 findbugs 0m 35s trunk passed
        +1 javadoc 0m 16s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 21s the patch passed
        +1 compile 0m 18s the patch passed
        +1 javac 0m 18s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 42s the patch passed
        +1 javadoc 0m 15s the patch passed
              Other Tests
        +1 unit 0m 37s hadoop-mapreduce-examples in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        24m 40s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HADOOP-14884
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888207/HADOOP-14884.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5decf6266605 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 53047f9
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13334/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13334/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 18m 2s trunk passed +1 compile 0m 24s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 21s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 16s trunk passed       Patch Compile Tests +1 mvninstall 0m 21s the patch passed +1 compile 0m 18s the patch passed +1 javac 0m 18s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 15s the patch passed       Other Tests +1 unit 0m 37s hadoop-mapreduce-examples in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 24m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HADOOP-14884 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888207/HADOOP-14884.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5decf6266605 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 53047f9 Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13334/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13334/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for the patch!

        +1 lgtm. Committing this.

        Show
        jlowe Jason Lowe added a comment - Thanks for the patch! +1 lgtm. Committing this.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s MAPREDUCE-6964 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue MAPREDUCE-6964
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888207/HADOOP-14884.patch
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7148/console
        Powered by Apache Yetus 0.5.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s MAPREDUCE-6964 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue MAPREDUCE-6964 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888207/HADOOP-14884.patch Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7148/console Powered by Apache Yetus 0.5.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Chetna Chaudhari! I committed this to trunk, branch-3.0, and branch-2.

        Show
        jlowe Jason Lowe added a comment - Thanks, Chetna Chaudhari ! I committed this to trunk, branch-3.0, and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12936 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12936/)
        MAPREDUCE-6964. BaileyBorweinPlouffe should use Time.monotonicNow for (jlowe: rev b9db0afa1e65d0343ad4e5760c36e042a3e704b0)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/BaileyBorweinPlouffe.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12936 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12936/ ) MAPREDUCE-6964 . BaileyBorweinPlouffe should use Time.monotonicNow for (jlowe: rev b9db0afa1e65d0343ad4e5760c36e042a3e704b0) (edit) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/BaileyBorweinPlouffe.java
        Hide
        chetna Chetna Chaudhari added a comment -

        Thanks Jason Lowe for reviewing and committing this patch.

        Show
        chetna Chetna Chaudhari added a comment - Thanks Jason Lowe for reviewing and committing this patch.

          People

          • Assignee:
            chetna Chetna Chaudhari
            Reporter:
            chetna Chetna Chaudhari
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development