Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6940

Copy-paste error in the TaskAttemptUnsuccessfulCompletionEvent constructor

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This constructor seems to be copy-pasted from another one, but it doesn't pass allSplits parameter as expected.

      Lines 126-133:

        public TaskAttemptUnsuccessfulCompletionEvent
            (TaskAttemptID id, TaskType taskType,
             String status, long finishTime,
             String hostname, int port, String rackName,
             String error, int[][] allSplits) {
          this(id, taskType, status, finishTime, hostname, port,
              rackName, error, EMPTY_COUNTERS, null);
        }
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dosoft opened a pull request:

          https://github.com/apache/hadoop/pull/263

          MAPREDUCE-6940: Pass allSplits parameter

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dosoft/hadoop MAPREDUCE-6940

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/263.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #263


          commit 045f1f5bc0aa65c6d19a1411c631ecb2d61659a4
          Author: Oleg Danilov <oleg@olegd.com>
          Date: 2017-08-16T13:09:54Z

          MAPREDUCE-6940: Pass allSplits parameter


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dosoft opened a pull request: https://github.com/apache/hadoop/pull/263 MAPREDUCE-6940 : Pass allSplits parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/dosoft/hadoop MAPREDUCE-6940 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #263 commit 045f1f5bc0aa65c6d19a1411c631ecb2d61659a4 Author: Oleg Danilov <oleg@olegd.com> Date: 2017-08-16T13:09:54Z MAPREDUCE-6940 : Pass allSplits parameter
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 31s Docker mode activated.
                Prechecks
          +1 @author 0m 1s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 24m 12s trunk passed
          +1 compile 0m 53s trunk passed
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 findbugs 1m 28s trunk passed
          +1 javadoc 0m 41s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 47s the patch passed
          +1 javac 0m 47s the patch passed
          -1 checkstyle 0m 29s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 1 new + 30 unchanged - 1 fixed = 31 total (was 31)
          +1 mvnsite 0m 52s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 41s the patch passed
          +1 javadoc 0m 37s the patch passed
                Other Tests
          +1 unit 4m 5s hadoop-mapreduce-client-core in the patch passed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          40m 18s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue MAPREDUCE-6940
          GITHUB PR https://github.com/apache/hadoop/pull/263
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f2e78b397067 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 588c190
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7077/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7077/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7077/console
          Powered by Apache Yetus 0.5.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 31s Docker mode activated.       Prechecks +1 @author 0m 1s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 24m 12s trunk passed +1 compile 0m 53s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 0m 57s trunk passed +1 findbugs 1m 28s trunk passed +1 javadoc 0m 41s trunk passed       Patch Compile Tests +1 mvninstall 0m 47s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed -1 checkstyle 0m 29s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 1 new + 30 unchanged - 1 fixed = 31 total (was 31) +1 mvnsite 0m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 41s the patch passed +1 javadoc 0m 37s the patch passed       Other Tests +1 unit 4m 5s hadoop-mapreduce-client-core in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 40m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue MAPREDUCE-6940 GITHUB PR https://github.com/apache/hadoop/pull/263 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f2e78b397067 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 588c190 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7077/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7077/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7077/console Powered by Apache Yetus 0.5.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          +1 lgtm. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Oleg! I committed this to trunk and branch-2.

          Show
          jlowe Jason Lowe added a comment - Thanks, Oleg! I committed this to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12198 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12198/)
          MAPREDUCE-6940. Copy-paste error in the (jlowe: rev 0acc5e00362602f027524637a86ca1bf80982986)

          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/TaskAttemptUnsuccessfulCompletionEvent.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12198 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12198/ ) MAPREDUCE-6940 . Copy-paste error in the (jlowe: rev 0acc5e00362602f027524637a86ca1bf80982986) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/TaskAttemptUnsuccessfulCompletionEvent.java

            People

            • Assignee:
              olegd Oleg Danilov
              Reporter:
              olegd Oleg Danilov
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development