Hudson added a comment - 01/Aug/17 06:28 SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12088 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12088/ ) MAPREDUCE-6921 . TestUmbilicalProtocolWithJobToken#testJobTokenRpc fails. (aajisaka: rev ceacadc51e58bb94ad3f3669488515a61e886d88) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/security/TestUmbilicalProtocolWithJobToken.java

Akira Ajisaka added a comment - 01/Aug/17 06:07 Committed this to trunk and branch-2. Thanks Sonia Garudi for the contribution and thanks Wenxin He for the review. Sorry I forgot to add the contributor name to the commit message.

Akira Ajisaka added a comment - 01/Aug/17 05:47 MAPREDUCE-precommit job seems do not check this no indent situation.There's no checkstyle warning or some else warning. Umm. It seems Apache Yetus should be upgraded to 0.5.0. ( YETUS-489 ). LGTM, +1 pending Jenkins.

Hadoop QA added a comment - 01/Aug/17 05:45 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 7s trunk passed +1 compile 0m 26s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 21s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 22s the patch passed +1 javac 0m 22s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 106m 12s hadoop-mapreduce-client-jobclient in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 126m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue MAPREDUCE-6921 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879766/MAPREDUCE-6921.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1f9110b706a7 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a4aa1cb Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7033/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7033/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.

Sonia Garudi added a comment - 01/Aug/17 03:35 Wenxin He I have updated the patch again. Could you please review? Thanks.

Wenxin He added a comment - 01/Aug/17 03:17 Strange, Akira Ajisaka , MAPREDUCE-precommit job seems do not check this no indent situation.There's no checkstyle warning or some else warning.

Wenxin He added a comment - 01/Aug/17 03:12 Thanks for your updating, Sonia Garudi . One more nit: would you please indent two spaces per level like this, according to HowToContribute 's "Making Changes" section? static { - ((Log4JLogger) Client.LOG).getLogger().setLevel(Level.ALL); - ((Log4JLogger) Server.LOG).getLogger().setLevel(Level.ALL); - ((Log4JLogger) SaslRpcClient.LOG).getLogger().setLevel(Level.ALL); - ((Log4JLogger) SaslRpcServer.LOG).getLogger().setLevel(Level.ALL); - ((Log4JLogger) SaslInputStream.LOG).getLogger().setLevel(Level.ALL); + GenericTestUtils.setLogLevel(Client.LOG, Level.TRACE); + GenericTestUtils.setLogLevel(Server.LOG, Level.TRACE); + GenericTestUtils.setLogLevel(SaslRpcClient.LOG, Level.TRACE); + GenericTestUtils.setLogLevel(SaslRpcServer.LOG, Level.TRACE); + GenericTestUtils.setLogLevel(SaslInputStream.LOG, Level.TRACE); }

Hadoop QA added a comment - 31/Jul/17 08:22 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 12s trunk passed +1 compile 0m 25s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 23s the patch passed +1 compile 0m 22s the patch passed +1 javac 0m 22s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 103m 33s hadoop-mapreduce-client-jobclient in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 123m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue MAPREDUCE-6921 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879567/MAPREDUCE-6921.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2547d093149c 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 481385e Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7031/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7031/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.

Sonia Garudi added a comment - 31/Jul/17 06:24 Thanks Akira Ajisaka and Wenxin He for the review. I have updated the patch.

Wenxin He added a comment - 31/Jul/17 03:02 Also, there's an extra whitespace between "=" and "getLogger(...". It would be better if this extra whitespace is removed. + public static final Logger LOG = getLogger(TestUmbilicalProtocolWithJobToken.class);

Wenxin He added a comment - 31/Jul/17 02:49 Thanks, Sonia Garudi and Akira Ajisaka . It's HADOOP-14539 that broke the test. Thanks for fixing it.

Akira Ajisaka added a comment - 28/Jul/17 11:56 I investigated what broke the test and found HADOOP-14539 . Please fix the link if it is not true.

Akira Ajisaka added a comment - 28/Jul/17 11:51 Thanks Sonia Garudi for reporting this issue and providing the patch. LGTM except tabs. Would you replace the tabs to 2 whitespaces?

Hadoop QA added a comment - 28/Jul/17 08:38 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 30s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 17m 31s trunk passed +1 compile 0m 30s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 15s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 26s the patch passed +1 javac 0m 26s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 30s the patch passed +1 mvneclipse 0m 21s the patch passed -1 whitespace 0m 0s The patch 5 line(s) with tabs. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 114m 37s hadoop-mapreduce-client-jobclient in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 139m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue MAPREDUCE-6921 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879305/MAPREDUCE-6921.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fd312ce64bc4 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 38c6fa5 Default Java 1.8.0_131 findbugs v3.1.0-RC1 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7030/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7030/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7030/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.

Sonia Garudi added a comment - 28/Jul/17 06:19 Akira Ajisaka could you please review the patch ?

Sonia Garudi added a comment - 28/Jul/17 04:29 The error is introduced post the HADOOP-14289 commit due to migration from log4j APIs to slf4j.